[Webkit-unassigned] [Bug 98889] [EFL][WK2] Add APIs for cache model

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=98889





--- Comment #3 from Christophe Dumez <christophe.dumez at intel.com>  2012-10-14 22:50:46 PST ---
(From update of attachment 168624)
View in context: https://bugs.webkit.org/attachment.cgi?id=168624&action=review

> Source/WebKit2/UIProcess/API/efl/ewk_context.cpp:323
> +    switch (cacheModel) {

How about using COMPILE_ASSERT_MATCHING_ENUM() from ewk_private so that we can use casting instead of a switch?

> Source/WebKit2/UIProcess/API/efl/ewk_context.h:58
> +    EWK_CACHE_MODEL_DOCUMENT_VIEWER,

Missing documentation for each enum value.

> Source/WebKit2/UIProcess/API/efl/ewk_context.h:282
> + */

Missing documentation for return value.

> Source/WebKit2/UIProcess/API/efl/ewk_context.h:292
> +EAPI Ewk_Cache_Model ewk_context_cache_model_get(Ewk_Context *context);

Argument should be const.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_context.cpp:180
> +    ASSERT_TRUE(ewk_context_cache_model_set(context, EWK_CACHE_MODEL_DOCUMENT_VIEWER));

Please add a test for the default value as well.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.