[Webkit-unassigned] [Bug 93925] :before/:after pseudo elements do not always apply to the proper element

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=93925





--- Comment #9 from Takashi Sakamoto <tasak at google.com>  2012-10-14 22:41:33 PST ---
(From update of attachment 164480)
View in context: https://bugs.webkit.org/attachment.cgi?id=164480&action=review

Thank you for reviewing.

>> Source/WebCore/ChangeLog:8
>> +        Disable sharing a style with sibligs if :after or :before pseudo style
> 
> sibligs => siblings

Thanks. Done.

>> Source/WebCore/rendering/style/RenderStyle.cpp:264
>> +    if (!m_cachedPseudoStyles || !m_cachedPseudoStyles->size())
> 
> I don't think this size() check is needed since the loop would just never run. Can you remove it and combine this and the below if statement?

Sure. Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.