[Webkit-unassigned] [Bug 98733] [WK2] Add CustomFilterOperation serialization in ArgumentCoder.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Oct 14 21:06:57 PDT 2012
https://bugs.webkit.org/show_bug.cgi?id=98733
Huang Dongsung <luxtella at company100.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #168595|1 |0
is obsolete| |
--- Comment #25 from Huang Dongsung <luxtella at company100.net> 2012-10-14 21:07:43 PST ---
(From update of attachment 168595)
View in context: https://bugs.webkit.org/attachment.cgi?id=168595&action=review
>> Source/WebKit2/ChangeLog:10
>> + Shaders.
>
> Please remove these lines.
Done.
>> Source/WebKit2/ChangeLog:30
>> + custom filter program via network.
>
> Just say "WebCustomFilterProgram is made to serialize the data of a StyleCustomFilterProgram to the UI process."
Done. Thanks for rephrasing
>>> Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:29
>>> +#if USE(COORDINATED_GRAPHICS)
>>
>> Put this line after the main include
>
> Do I mean like following code? I don't understand fully what do you say.
> #include "config.h"
> #include "CoordinatedGraphicsArgumentCoders.h"
> #if USE(COORDINATED_GRAPHICS)
>
>
> These code are similar to GraphicsContext3D.
> #include "config.h"
>
> #if USE(3D_GRAPHICS)
>
> #include "GraphicsContext3D.h"
Done as I understood. Check please.
>> Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:150
>> + encoder->encodeEnum(parameters[i]->parameterType());
>
> Please save parameters[i] in a local variable.
Done.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list