[Webkit-unassigned] [Bug 97651] [EFL] Make PageClient accessible to both WebKit and WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=97651





--- Comment #2 from Ryuan Choi <ryuan.choi at samsung.com>  2012-10-14 16:08:53 PST ---
(From update of attachment 168381)
View in context: https://bugs.webkit.org/attachment.cgi?id=168381&action=review

> Source/WebCore/platform/efl/WebPageClientEfl.h:23
> +#include <Evas.h>

Can we just declare some types istead of include Evas.h in header file.

> Source/WebCore/platform/efl/WebPageClientEfl.h:30
> +class WebPageClientEfl {

What do you think about adding this in WebCore namespae?

> Source/WebCore/platform/graphics/efl/GraphicsContext3DPrivate.cpp:52
> +    WebPageClientEfl* pageClient = 0;

Can we move this below 54 line.

> Source/WebCore/platform/graphics/efl/GraphicsContext3DPrivate.cpp:63
> +                sharedContext = static_cast<Evas_GL_Context*>(context->platformGraphicsContext3D());

Can I know the meaning of this?

I could not find usage of this value.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.