[Webkit-unassigned] [Bug 88606] [Shadow DOM] Needs @host rule for ShadowDOM styling

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=88606





--- Comment #37 from Takashi Sakamoto <tasak at google.com>  2012-10-12 06:41:04 PST ---
(From update of attachment 168155)
View in context: https://bugs.webkit.org/attachment.cgi?id=168155&action=review

Thank you for reviewing.

>> Source/WebCore/css/RuleSet.h:50
>> +    RuleData(StyleRule*, unsigned selectorIndex, unsigned position, unsigned addRuleState);
> 
> Coud you use AddRuleState instead of unsigned?

I see. Done.

>> Source/WebCore/css/StyleResolver.cpp:438
>> +void StyleResolver::addHostRule(StyleRuleHost* hostRule, bool hasDocumentSecurityOrigin, const ContainerNode* scope)
> 
> Can we move this implementation more to StyleScopeResolver?
> Ideally all @host related code should be owned by StyleScopeResolver.
> I know it's unfeasible for now. But I think we could be better here.

I see. I moved.... 
So I created a new method to ensure m_scopeResolver, i.e. ensureScopeResolver to create (if needed) and obtain m_scopeResolver. Is this ok...?

>> Source/WebCore/css/StyleResolver.cpp:440
>> +#if ENABLE(STYLE_SCOPED)
> 
> This isn't related STYLE_SCOPED. This should be part of SHAODW_ROOT.

I see. I modified to use ENABLE(SHADOW_DOM).

>> Source/WebCore/css/StyleResolver.cpp:781
>> +#if ENABLE(STYLE_SCOPED)
> 
> Ditto.

Done.

>> Source/WebCore/css/StyleResolver.cpp:790
>> +#if ENABLE(STYLE_SCOPED)
> 
> Ditto.

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.