[Webkit-unassigned] [Bug 84885] [Resource Timing] Implement buffer limits

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84885


pdeng6 <pan.deng at intel.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pan.deng at intel.com




--- Comment #11 from pdeng6 <pan.deng at intel.com>  2012-10-12 00:34:36 PST ---
(In reply to comment #10)
> View in context: https://bugs.webkit.org/attachment.cgi?id=161955&action=review
> 
> > Source/WebCore/page/Performance.cpp:54
> > +    m_resourceTimingBufferSize = defaultResourceTimingBufferSize;
> 
> This should be in the initializer list.
> 
> > Source/WebCore/page/Performance.cpp:154
> > +        dispatchEvent(Event::create(eventNames().webkitresourcetimingbufferfullEvent, false, false));
> 
> This event is only supposed to fire once when it becomes full, not on every resource that arrives after it's full.
> 
> If the user clears the buffer during the event, then we should go ahead and record this resource.
> 
Good point.
> I started a thread about this on web-perf. My goal for the thread was to fire the event after append() makes it full.
one exception is, what if a smaller buffer size is set when previous buffer size is not achieved yet? an extreme scenario is buffer size is set to 0 before any append() happen, I prefer fire the event in this condition if that is not fired on every resource that arrives after full.

in addition, resource timing[1] said, "While executing the onresourcetimingbufferfull callback, PerformanceResourceTiming will continue to be collected beyond the maximum limit of the resources allowed in the PerformanceResourceTiming interface until...", seems this statement intends to ensure no resource timing entry loss when buffer is full. has it been discussed in web perf group?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.