[Webkit-unassigned] [Bug 99118] JSC Should atomize constant strings before handing them to WebCore

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=99118


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |haraken at chromium.org




--- Comment #3 from Eric Seidel <eric at webkit.org>  2012-10-11 19:19:54 PST ---
Looking at the sample more, it looks like this is more like avoiding AtomicString lookup due to Identifier/AtomicString StringImpl* mismatches has the potential to be more like at 15+% win on dom-query.html:

Running Time    Self        Symbol Name
3472.0ms    7.5%    3472.0         WTF::HashTableAddResult<WTF::HashTableIterator<WTF::StringImpl*, WTF::StringImpl*, WTF::IdentityExtractor, WTF::StringHash, WTF::HashTraits<WTF::StringImpl*>, WTF::HashTraits<WTF::StringImpl*> > > WTF::HashTable<WTF::StringImpl*, WTF::StringImpl*, WTF::IdentityExtractor, WTF::StringHash, WTF::HashTraits<WTF::StringImpl*>, WTF::HashTraits<WTF::StringImpl*> >::add<WTF::IdentityHashTranslator<WTF::StringHash>, WTF::StringImpl*, WTF::StringImpl*>(WTF::StringImpl* const&, WTF::StringImpl* const&)
1615.0ms    3.4%    1615.0         WTF::StringHash::equal(WTF::StringImpl const*, WTF::StringImpl const*)
1524.0ms    3.2%    1524.0         WTF::AtomicString::addSlowCase(WTF::StringImpl*)
561.0ms    1.2%    561.0         WTF::StringImpl::hashSlowCase() const

Are all samples which stem from this in dom-query.html. :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.