[Webkit-unassigned] [Bug 98800] RoboHornetPro spends ~25% of total test time in WebCore::Region::Shape methods

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 11 14:16:59 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=98800





--- Comment #8 from Eric Seidel <eric at webkit.org>  2012-10-11 14:17:40 PST ---
I wrote a patch to do #2 (pre-allocate vectors of the correct size).  I am not sure I guessed the sizes 100% correctly, as I still see a few fastMalloc's where I wouldn't expect them, but it was a small win.

I don't think #2 is worth doing.  #1 is where the real money is.

It's also unclear to me how exactly the OverlayMap is used -- if it's written to more than it's read from, for instance.  An OverlayMap which is smart enough to normally use a Vector<IntRect> and only convert to a Region when necessary might be possible and might be a bigger win even than making Region::union fast. :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list