[Webkit-unassigned] [Bug 88094] Web Inspector: Add a WebInspectorServer on Linux using the GSocket API for the GTK port

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 11 05:01:38 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=88094





--- Comment #39 from Seokju Kwon <seokju.kwon at samsung.com>  2012-10-11 05:02:17 PST ---
(In reply to comment #36)
> (From update of attachment 167539 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=167539&action=review
> 
> > Source/WebKit2/UIProcess/InspectorServer/WebSocketServer.h:40
> > +#elif PLATFORM(GTK)
> 
> Shouldn't this be #elif USE(SOUP), instead? Then both GTK and EFL could benefit from it.
> Also, I would move this entire block up, before the #if PLATFORM(QT), since it is related to includes and not namespaces/forward declarations.

I want to use 'WebSocketServer' using g_socket_service on efl port.
Should I copy WebSocketServerGtk.cpp to WebSocketServerEfl.cpp? or make a shareable directory for gtk/efl?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list