[Webkit-unassigned] [Bug 88196] REGRESSION (r96393): In some cases, generated content is never shown

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=88196





--- Comment #14 from Arpita Bahuguna <arpitabahuguna at gmail.com>  2012-10-11 05:01:57 PST ---
(In reply to comment #12)
> (From update of attachment 149911 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=149911&action=review
> 
Hi Antti, Thank-you for the review comments.
Have uploaded another patch with the suggested changes.

> The fix looks good but I think this can be factored nicer.
> 
> > Source/WebCore/css/StyleResolver.cpp:1715
> > +        m_checker.setMode(SelectorChecker::SharingRules);
> >          RenderStyle* sharedStyle = locateSharedStyle();
> > +        m_checker.setMode(SelectorChecker::ResolvingStyle);
> 
> I think you should set and restore the mode nearer to the SelectorChecker call site. The most natural place would probably be matchesRuleSet() function (which is only used by locateSharedStyle() and should be the only way to call the SelectorChecker there). That function should also be renamed to something more descriptive, styleSharingCandidateMatchesRuleSet() for example.

Moving the SelectorChecker Mode set/reset closer to the call definitely makes more sense. Am now setting the same before making our collectMatchingRules() call from matchesRuleSet() which too has now been renamed to styleSharingCandidateMatchesRuleSet() as per your suggestion.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.