[Webkit-unassigned] [Bug 98885] [GTK] It should be possible to disable favicons in WebKit2 GTK+ API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=98885


Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #168171|review?                     |review+
               Flag|                            |




--- Comment #13 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-10-11 02:05:22 PST ---
(From update of attachment 168171)
View in context: https://bugs.webkit.org/attachment.cgi?id=168171&action=review

> Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp:407
> + * Get the #WebKitFaviconDatabase associated with @context

@context.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp:412
> + * Notice that this method simply returns the #WebKitFaviconDatabase,
> + * but doesn't enable the database. To enable it you will still need to
> + * call webkit_web_context_set_favicon_database_directory() at least
> + * once, either before or after calling this method.

I think I would avoid using enable/disable, because the error you get from the favicon database is NOT_INITIALIZED. I would simplify this by something like. 

"To initialize the database you need to call webkit_web_context_set_favicon_database_directory()."

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.