[Webkit-unassigned] [Bug 98885] [GTK] It should be possible to disable favicons in WebKit2 GTK+ API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=98885





--- Comment #9 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-10-11 00:20:24 PST ---
(From update of attachment 168005)
View in context: https://bugs.webkit.org/attachment.cgi?id=168005&action=review

>> Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp:353
>> +        priv->faviconDatabase = adoptGRef(webkitFaviconDatabaseCreate(iconDatabase));
> 
> I prefer a single point where the database is created. Also I would move the setIconDatabasePath to WebKitFaviconDatabase using a private method. So you can remove this here and below call something like
> 
> webkitFaviconDatabaseSetPath(webkit_web_context_get_favicon_database(context), faviconDatabasePath.get());

Oh, I see, the setIconDatabasePath is in web context, so it's better to do it here, for get this comment, sorry.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.