[Webkit-unassigned] [Bug 98639] [EFL][WK2] Add support for Inspector

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=98639





--- Comment #10 from Christophe Dumez <christophe.dumez at intel.com>  2012-10-10 22:29:40 PST ---
(From update of attachment 168100)
View in context: https://bugs.webkit.org/attachment.cgi?id=168100&action=review

> Source/WebKit2/UIProcess/efl/WebInspectorProxyEfl.cpp:45
> +    ecore_evas_geometry_get(inspectorWindow, 0, 0, &width, &height);

These 2 lines should be moved after the inspectorView NULL-check.

> Source/WebKit2/UIProcess/efl/WebInspectorProxyEfl.cpp:48
> +    if (inspectorView) {

if (!inspectorView)
    return;

Returning early is more commonly used pattern in WebKit.

> Source/WebKit2/UIProcess/efl/WebInspectorProxyEfl.cpp:54
> +static void destoryInspectorWindow(Ecore_Evas* inspectorWindow)

"destroy"

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.