[Webkit-unassigned] [Bug 88196] REGRESSION (r96393): In some cases, generated content is never shown

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=88196


Antti Koivisto <koivisto at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #149911|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #12 from Antti Koivisto <koivisto at iki.fi>  2012-10-10 13:35:56 PST ---
(From update of attachment 149911)
View in context: https://bugs.webkit.org/attachment.cgi?id=149911&action=review

The fix looks good but I think this can be factored nicer.

> Source/WebCore/css/StyleResolver.cpp:1715
> +        m_checker.setMode(SelectorChecker::SharingRules);
>          RenderStyle* sharedStyle = locateSharedStyle();
> +        m_checker.setMode(SelectorChecker::ResolvingStyle);

I think you should set and restore the mode nearer to the SelectorChecker call site. The most natural place would probably be matchesRuleSet() function (which is only used by locateSharedStyle() and should be the only way to call the SelectorChecker there). That function should also be renamed to something more descriptive, styleSharingCandidateMatchesRuleSet() for example.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.