[Webkit-unassigned] [Bug 98913] Change transformation precision from double to float

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=98913





--- Comment #2 from Gabor Rapcsanyi <rgabor at webkit.org>  2012-10-10 11:29:24 PST ---
(In reply to comment #1)
> It used to be floats and was converted to doubles. Did you go through the file history?

There were a lot of file renaming and code moving etc but yes I checked the history of some files, but I still don't see when it changes to double from float.
You mentioned in your mail this bug (https://bugs.webkit.org/show_bug.cgi?id=6868) which I checked as well but when I watched the patch closer I still saw double parameters which were there before it.
So I tracked back the AffineTransform.h to see when it started using double but I've just found this:
http://trac.webkit.org/browser/trunk/WebCore/kwq/KWQWMatrix.h?annotate=blame&rev=9585
Which works with doubles.

I also checked the history of TransformationMatrix.h and I found this:
http://trac.webkit.org/browser/trunk/WebCore/rendering/style/RenderStyle.h?annotate=blame&rev=34535
It contains the MatrixTransformOperation class which is still using double parameters.

So I'm a little bit confused when we started using doubles for the transformations and why. But to make it clear I would like to change all doubles in Source/WebCore/platform/graphics/transforms to float or maybe it would be better to a typedef.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.