[Webkit-unassigned] [Bug 98885] [GTK] It should be possible to disable favicons in WebKit2 GTK+ API

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 10 07:59:39 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=98885





--- Comment #4 from Mario Sanchez Prada <msanchez at igalia.com>  2012-10-10 08:00:17 PST ---
(In reply to comment #2)
> I agree with the idea, yet I have some comments about the specific 
> implementation for it. See them below...

Forget about those comments. I realized that what you're suggesting is slightly different from what I've understood: you're proposing to decouple the process of creating the WebKitFaviconDatabase (which would happen both in get_favicon_database() and set_favicon_database_directory(), when needed) from the process of opening the IconDatabase, which would only happen in set_favicon_database_directory().

This way, one could call get_favicon_database() as many times as needed but it would not cause any effect until a call (and only) to set_favicon_database_directory() was invoked.

I'm already working on a patch for this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list