[Webkit-unassigned] [Bug 88094] Web Inspector: Add a WebInspectorServer on Linux using the GSocket API for the GTK port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=88094





--- Comment #38 from Yuta Kitamura <yutak at chromium.org>  2012-10-09 18:55:07 PST ---
(From update of attachment 167539)
View in context: https://bugs.webkit.org/attachment.cgi?id=167539&action=review

> Source/WebKit2/UIProcess/InspectorServer/gtk/WebSocketServerGtk.cpp:46
> +    GOwnPtr<gchar> addressStr(g_inet_address_to_string(g_inet_socket_address_get_address(G_INET_SOCKET_ADDRESS(socketAddress.get()))));

Abbreviation "Str" here, too. "addressString" would be fine.

>> Source/WebKit2/UIProcess/InspectorServer/gtk/WebSocketServerGtk.cpp:47
>> +    LOG(Network, "New Connection from %s:%d.", addressStr.get(), g_inet_socket_address_get_port(G_INET_SOCKET_ADDRESS(socketAddress.get())));
> 
> Shouldn't the #ifndef LOG_DISABLED be protecting only this line instead of all the 3 ones above?

I guess the original code is fine in this case because socketAddress and addressStr are only used within LOG().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.