[Webkit-unassigned] [Bug 97397] [BlackBerry] Fix assertion in NetworkJob::notifyChallengeResult.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 9 18:18:20 PDT 2012


--- Comment #8 from Lyon Chen <liachen at rim.com>  2012-10-09 18:18:57 PST ---
(In reply to comment #7)
> I disagree - url and protectionSpace are passed in as parameters, so they should be checked in case the call site changes. Just from looking at the function on its own its not clear that they're always correct, and we shouldn't require people to find every call site to reason about correctness. Or at least there should be an assert.

OK, I prefer the assertions, as these 2 values (the url here and host) are not user input, when there is a problem with url or protectionSpace host at this stage, it must be a software error.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list