[Webkit-unassigned] [Bug 97859] [CSS Shaders] Implement all composite operators except destination and lighter.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=97859


Dean Jackson <dino at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #167183|review?                     |review+
               Flag|                            |




--- Comment #20 from Dean Jackson <dino at apple.com>  2012-10-09 16:04:15 PST ---
(From update of attachment 167183)
View in context: https://bugs.webkit.org/attachment.cgi?id=167183&action=review

> Source/WebCore/platform/graphics/filters/CustomFilterValidatedProgram.cpp:294
>      case CompositePlusLighter:
>          notImplemented();
>          return String();
> +        // FIXME: destination and lighter were not implemented yet.

I don't think we need this comment. It's clear that they are not implemented.

> LayoutTests/css3/filters/custom/custom-filter-composite-operators.html:4
> +    <title>Tests that custom filter composite operators compute color values correctly.</title>

As Max originally suggested, it would be great if this could be a reftest, with the expected value shown next to each subtest. I wonder if we can be accurate enough by placing colored divs to replicate the blending. Anyway, this is ok for now.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.