[Webkit-unassigned] [Bug 98789] [GTK] Plugin don't display

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=98789


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #167828|review?                     |review-
               Flag|                            |




--- Comment #6 from Martin Robinson <mrobinson at webkit.org>  2012-10-09 13:05:14 PST ---
(From update of attachment 167828)
View in context: https://bugs.webkit.org/attachment.cgi?id=167828&action=review

> Source/WebKit/gtk/webkit/webkitwebview.cpp:-875
> -    gtk_widget_get_allocation(widget, &oldAllocation);
> -
>      GTK_WIDGET_CLASS(webkit_web_view_parent_class)->size_allocate(widget, allocation);
> -    if (allocation->width == oldAllocation.width && allocation->height == oldAllocation.height)
> -        return;

I think this is the wrong fix. Instead of simply ignoring whether or not the size has changed, you should pass the information to resizeWebViewFromAllocation and only keep the call to gtk_container_forall(GTK_CONTAINER(webView), updateChildAllocationFromPendingAllocation, 0); when the size hasn't changed. Please see the WebKitWebViewBase for an example.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.