[Webkit-unassigned] [Bug 93922] [Shadow DOM] Insertion points need resetStyleInheritance

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=93922


Dimitri Glazkov (Google) <dglazkov at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #167694|review?                     |review-
               Flag|                            |




--- Comment #9 from Dimitri Glazkov (Google) <dglazkov at chromium.org>  2012-10-09 10:29:07 PST ---
(From update of attachment 167694)
View in context: https://bugs.webkit.org/attachment.cgi?id=167694&action=review

This is getting close. We need to get CSS WG to go ahead and spec display: contents, so that we can redefine <content>/<shadow> in terms of that primitive, instead of the hacking this into StyleResolver.

> Source/WebCore/html/shadow/HTMLShadowElement.idl:37
> +        attribute boolean resetStyleInheritance;

What about adding the attribute to HTML?

>> Source/WebCore/html/shadow/InsertionPoint.h:81
>> +    bool m_resetStyleInheritance : 1;
> 
> It’s unfortunate that the shadow specification gives a property a verb phrase name. The function resetStyleInheritance sounds like something that would perform a reset operation, not a getter that returns a boolean.
> 
> We don’t have to repeat that mistake in our data member. I would suggest the name “m_shouldResetStyleInheritance” or at least “m_resetsStyleInheritance”, and also suggest discussing changing the name in the spec.

For what it's worth, since it reflects the "reset-style-inheritance" attribute on HTMLContentElement/HTMLShadowElement, I think the name falls well into the current naming convention for attributes, such as "autoplay", "autofocus", "defer", etc. http://www.whatwg.org/specs/web-apps/current-work/multipage/section-index.html#attributes-1

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.