[Webkit-unassigned] [Bug 97397] [BlackBerry] Fix assertion in NetworkJob::notifyChallengeResult.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=97397





--- Comment #7 from Joe Mason <jmason at rim.com>  2012-10-09 07:07:34 PST ---
(From update of attachment 165268)
View in context: https://bugs.webkit.org/attachment.cgi?id=165268&action=review

>>> Source/WebCore/platform/network/blackberry/NetworkJob.cpp:-849
>>> -    if (result != AuthenticationChallengeSuccess || protectionSpace.host().isEmpty() || !url.isValid()) {
>> 
>> What happened to the protectionSpace and url checks in the refactored code?
> 
> Sorry for the late response. I think the URL and protectionSpace checking is not necessary because if they are invalid we should fail somewhere already. For example url is checked before, and a url without host (or empty host) could not possibly asking for an authentication challenge.

I disagree - url and protectionSpace are passed in as parameters, so they should be checked in case the call site changes. Just from looking at the function on its own its not clear that they're always correct, and we shouldn't require people to find every call site to reason about correctness. Or at least there should be an assert.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.