[Webkit-unassigned] [Bug 88094] Web Inspector: Add a WebInspectorServer on Linux using the GSocket API for the GTK port

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 9 03:49:12 PDT 2012


--- Comment #35 from Jocelyn Turcotte <jocelyn.turcotte at digia.com>  2012-10-09 03:49:48 PST ---
(From update of attachment 167539)
View in context: https://bugs.webkit.org/attachment.cgi?id=167539&action=review

> Source/WebKit2/WebKit2.qrc:3
> -    <file alias="inspectorPageIndex.html">qt/Resources/inspectorPageIndex.html</file>
> +    <file alias="inspectorPageIndex.html">UIProcess/InspectorServer/front-end/inspectorPageIndex.html</file>

This patch should also remove the now unused file at Source/WebKit2/qt/Resources/inspectorPageIndex.html

> Source/WebKit2/UIProcess/gtk/WebContextGtk.cpp:55
> +        Vector<String> result;
> +        envStr.split(":", result);
> +
> +        if (result.size() == 2) {

I don't know how you intend to use WEBKIT_INSPECTOR_SERVER, but if users are going to fill it directly it might be good to give back some error message in cases where you couldn't parse the address/port or if you couldn't open the server.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list