[Webkit-unassigned] [Bug 97397] [BlackBerry] Fix assertion in NetworkJob::notifyChallengeResult.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=97397





--- Comment #6 from Lyon Chen <liachen at rim.com>  2012-10-08 20:23:41 PST ---
(In reply to comment #3)
> (From update of attachment 165268 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=165268&action=review
> 
> > Source/WebCore/platform/network/blackberry/NetworkJob.cpp:-849
> > -    if (result != AuthenticationChallengeSuccess || protectionSpace.host().isEmpty() || !url.isValid()) {
> 
> What happened to the protectionSpace and url checks in the refactored code?

Sorry for the late response. I think the URL and protectionSpace checking is not necessary because if they are invalid we should fail somewhere already. For example url is checked before, and a url without host (or empty host) could not possibly asking for an authentication challenge.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.