[Webkit-unassigned] [Bug 98631] Rename RenderObject::firstLineStyleSlowCase() to a more appropriate cachedFirstLineStyle()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=98631





--- Comment #4 from Elliott Sprehn <esprehn at chromium.org>  2012-10-08 09:47:12 PST ---
(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 167531 [details] [details])
> > It also fetches the first line style.  m_style/style() is where it's cached.  I don't think this change makes sense.
> 
> Can you explain what you mean? This is the same as getCachedPseudoStyle() and getUncachedPseudoStyle(). The naming right now doesn't make any sense to me because this isn't the slow case, it's just the default case when your document uses first line styles.

For reference, I requested this change because we have getUncached and getCached for pseudo styles, but first line has uncachedFirstLineStyle() and firstLineStyle() and firstLineStyleSlowCase of which the last one doesn't have a good name since it doesn't tell you what it's really doing. :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.