[Webkit-unassigned] [Bug 98507] [GTK] Test /webkit2/WebKitWebView/populate-menu asserts in debug bots

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=98507





--- Comment #4 from Mario Sanchez Prada <msanchez at igalia.com>  2012-10-08 01:55:23 PST ---
(From update of attachment 167305)
View in context: https://bugs.webkit.org/attachment.cgi?id=167305&action=review

The patch looks good to me too. A pity I didn't realize of this issue when writing the original patch, quite happy Carlos figured it out and fixed it, though.

> Source/WebKit2/UIProcess/API/gtk/WebKitFaviconDatabase.cpp:151
>      PendingIconRequestVector* icons = database->priv->pendingIconRequests.get(pageURL);

Completely off-topic thing: you might consider renaming this 'icons' variable before landing to something more adequate, such as 'pendingIconRequests', or something like that.

> Source/WebKit2/UIProcess/API/gtk/WebKitFaviconDatabase.cpp:156
> +    RefPtr<cairo_surface_t> icon = getIconSurfaceSynchronously(database, pageURL, &error.outPtr());

I like this refactoring: taking this call out of the loop. Good catch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.