[Webkit-unassigned] [Bug 96768] [GTK] Don't use the C API internally in WebKitWebContext

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=96768





--- Comment #8 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-10-06 00:36:01 PST ---
(In reply to comment #7)
> (From update of attachment 166480 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=166480&action=review
> 
> Looks good, but seems to violate one of the rules of the style guide. I don't see this as a huge issue, but it would be nice to follow the rule if it isn't too hard.
> 
> > Source/WebKit2/UIProcess/API/gtk/WebKitWebContextPrivate.h:36
> > +using namespace WebKit;
> 
> The style guide doesn't seem to like namespace declarations in the global scope in headers, since it leaks into implementation files: http://www.webkit.org/coding/coding-style.html (number 1 for "using" Statements).

I think this is a special case because it's not a C++ header, but a private header to add prototypes of some internal functions. 

> There are a couple things you can do to make your life easier here though:
> 
> 1. Put the private methods in the WebKit namespace.
> 2. Use WebKit:: in the header and put using WebKit at the top of the files that include this file.

Since we are already doing it, and all C API migration patches do it too, do you mind if I fix it all together afterwards?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.