[Webkit-unassigned] [Bug 98396] [CSS Shaders] Make custom filters use a premultiplied buffer.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=98396





--- Comment #8 from Max Vujovic <mvujovic at adobe.com>  2012-10-05 12:13:40 PST ---
(From update of attachment 167281)
Thanks for the updates, Huang. This looks good to me- just minor ChangeLog nits if you want to fix them. You should probably ask Dean to review this formally now, since I'm only a committer :)

View in context: https://bugs.webkit.org/attachment.cgi?id=167281&action=review

> Source/WebCore/ChangeLog:8
> +        Currently, a glsl css_Composite function returns a premultiplied color, so

Capitalization nit: GLSL

> Source/WebCore/ChangeLog:14
> +        2. In the future when AC implementaions use FECustomFilter, they do not need to

Spelling nit: implementations

> Source/WebCore/platform/graphics/filters/FECustomFilter.cpp:227
> +    Uint8ClampedArray* dstPixelArray = m_validatedProgram->programInfo().mixSettings().enabled ? createPremultipliedImageResult() : createUnmultipliedImageResult();

In the near future, we will be removing mixSettings.enabled.

So instead of:
(1) m_validatedProgram->programInfo().mixSettings().enabled

We will write:
(2) m_validatedProgram->programInfo().programType() == PROGRAM_TYPE_BLENDS_ELEMENT_TEXTURE

You can write (2) right now because until we get rid of mixSettings.enabled, programType() does this:
CustomFilterProgramType programType() const { return m_mixSettings.enabled ? PROGRAM_TYPE_BLENDS_ELEMENT_TEXTURE : PROGRAM_TYPE_NO_ELEMENT_TEXTURE; }

Michelangelo is working on removing mixSettings.enabled in bug 96448, so it's not your responsibility to change (1) to (2) now, but you can if you want :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.