[Webkit-unassigned] [Bug 96627] [EFL] Use the shareable GraphicsContext3DOpenGL* implementation.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=96627





--- Comment #20 from Regina Chung <heejin.r.chung at samsung.com>  2012-10-04 18:22:12 PST ---
(In reply to comment #19)
> (In reply to comment #16)
> > (In reply to comment #15)
> > > (From update of attachment 166164 [details] [details] [details])
> > > View in context: https://bugs.webkit.org/attachment.cgi?id=166164&action=review
> > > 
> > > >> Source/WebCore/platform/graphics/efl/GraphicsContext3DPrivate.cpp:43
> > > >> +    if (renderStyle == GraphicsContext3D::RenderToCurrentGLContext)
> > > > 
> > > > There seems to be an inconsistency here. GraphicsContext3D::createForCurrentGLContext() sets renderStyle to GraphicsContext3D::RenderToCurrentGLContext.
> > > > So we always return here without creating a GL context.
> > > 
> > > That seems generally correct, doesn't it? There's no surface, etc. to create in that case, no?
> > The context that we are supposed to create here is used as key for the hash table. Not creating one, as proposed by this patch, triggers ASSERT in debug builds.
> I should set m_evasGLContext and m_surface to the current values, but Evas doesn't provide any APIs to query them :(
> I guess I'll just have to query the current context and surface using egl in GC3D and set the GC3DPrivate values with them.
Actually, it will be glX functions for OpenGL and EGL functions for OpenGL ES.

> (EvasGL and EGL APIs can't be used in the same source files so I'll need to call the EGL functions from GC3DEfl.cpp)
> Do you think that will be okay? Or do you have another suggestion?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.