[Webkit-unassigned] [Bug 98131] Add ARM-NEON support to VectorMath in WebAudio

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=98131





--- Comment #12 from Zoltan Herczeg <zherczeg at webkit.org>  2012-10-04 15:00:03 PST ---
(In reply to comment #5)
> (In reply to comment #3)
> > (From update of attachment 166684 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=166684&action=review
> > 
> > > Source/WebCore/platform/audio/VectorMath.cpp:632
> > > +        max = std::max(max, groupMax[0]);
> > > +        max = std::max(max, groupMax[1]);
> > > +        max = std::max(max, groupMax[2]);
> > > +        max = std::max(max, groupMax[3]);
> > 
> > Can't we use vmax here?
> 
> Unfortunately we can't because vmax is working on vectors and the result will be a vector as well. There is no function which gives you the highest value from a vector.

Hm true, but still you can reduce it by one max:

max(a,b,c,d):
  t1 = max(a,b);
  t2 = max(c,d);
  return max(t1,t2)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.