[Webkit-unassigned] [Bug 98396] [CSS Shaders] Make custom filters use a premultiplied buffer.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=98396





--- Comment #4 from Huang Dongsung <luxtella at company100.net>  2012-10-04 14:55:09 PST ---
(In reply to comment #2)
> In this case, we can't guarantee the author has premultiplied the gl_FragColor output. Thus, we have to add a condition:
> 
> Uint8ClampedArray* dstPixelArray = (m_validatedProgram->programInfo().programType == PROGRAM_TYPE_NO_ELEMENT_TEXTURE ? createUnmultipliedImageResult() : createPremultipliedImageResult());

Thanks for your instruction! I completely missed this. I used m_validatedProgram->programInfo().mixSettings().enabled like the constructor of CustomFilterValidatedProgram.

I hope dstPixelArray will be premultiplied even if an author is not using the CSS mix function in the future when AC implementations use FECustomFilter.

> Nice test! I think this should say:
> "Tests the source-atop composite operator when source alpha is a fractional value."
> 
> I would also rename the test to something like:
> custom-filter-composite-fractional-source-alpha.html

Thanks for proofreading. The changed words are so much natural!

> If you land this before bug 97859, you'll want to use source-atop, since we don't have source-over yet.

Sounds good! I'll do that.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.