[Webkit-unassigned] [Bug 97859] [CSS Shaders] Implement all composite operators except destination and lighter.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=97859





--- Comment #17 from Max Vujovic <mvujovic at adobe.com>  2012-10-04 10:52:54 PST ---
(From update of attachment 167067)
Looking great! Thanks for the updates.

View in context: https://bugs.webkit.org/attachment.cgi?id=167067&action=review

> Source/WebCore/platform/graphics/filters/CustomFilterValidatedProgram.cpp:310
> +            return vec4((as * Fa * Cs + ab * Fb * Cb) / ao, ao);

This change is unrelated to the compositing modes, so I would take it out. I think you should land bug 98396 first, since you're removing this change in there. That is, refactor first, and then add new functionality.

> LayoutTests/css3/filters/custom/custom-filter-composite-operators.html:4
> +    <title>Tests that custom filter composite operators compute color values correctly.</title>

This test looks great! Thanks for making it. Do you think it can be a ref test instead of a pixel test?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.