[Webkit-unassigned] [Bug 98334] [EFL][WK2] Fix destination path when download with suggested filename on the Minibrowser

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=98334





--- Comment #12 from Christophe Dumez <christophe.dumez at intel.com>  2012-10-04 01:42:36 PST ---
(From update of attachment 167048)
View in context: https://bugs.webkit.org/attachment.cgi?id=167048&action=review

> Tools/ChangeLog:10
> +        The 'destination folder' should be a specific folder user selected, but now set to '/tmp' temporary.

"but now set to '/tmp' temporary." -> "but is set to '/tmp' for now". "temporary" is not correct here I believe.

> Tools/MiniBrowser/efl/main.c:205
> +    // FIX ME: destination folder should be user-selectable. Set it as "/tmp" temporary.  

This comment is still incorrect "FIX ME" -> "FIXME" and the last sentence is not correct English I believe. Please check the comment I proposed in my earlier review.

> Tools/MiniBrowser/efl/main.c:213
> +        eina_strbuf_append(destination_path, "Downloaded_File_From_EFL_Minibrowser");

This is going to cause overwriting trouble. You should probably generate a unique name, as I suggested in my earlier review. You can use mktemp() for example. You can use test_ewk2_download_job.cpp as reference.

> Tools/MiniBrowser/efl/main.c:273
> +    evas_object_smart_callback_add(app->browser, "download,request", on_download_request, app);

Please keep the signals sorted.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.