[Webkit-unassigned] [Bug 21022] bugs.webkit.org should discourage patches larger than 20k (or some arbitrary size)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=21022


anitria <anitriaa44 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |anitriaa44 at gmail.com




--- Comment #1 from anitria <anitriaa44 at gmail.com>  2012-10-04 00:55:59 PST ---
(In reply to comment #0)
> bugs.webkit.org should discourage patches larger than 20k (or some arbitrary size)
> 
> I think our tools could assist us here.  I think it could be helpful towards education of contributers, and towards sanity of reviewers, if bugs.webkit.org would display some sort of warning page when you tried to upload a patch which was larger than 50k/20k or some arbitrary size.  Especially when non-committers or first-time contributers upload 100k patches, its just a waste of reviewers time and their time, trying to fight it down to something that's more reviewable.  I don't think technology is the final solution to that problem, but making it clear during the patch upload process that your patch exceeds the "sane" size limit, could be useful.
> 
> Heck there are other things bugzilla (or other scripts/tools) could scan for, like lack of ChangeLog too... but that's the subject for another bug.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.