[Webkit-unassigned] [Bug 61675] <input> size attribute does not return default when attribute outofrange

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61675


Kent Tamura <tkent at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #167035|review?                     |review-
               Flag|                            |




--- Comment #5 from Kent Tamura <tkent at chromium.org>  2012-10-03 23:16:07 PST ---
(From update of attachment 167035)
View in context: https://bugs.webkit.org/attachment.cgi?id=167035&action=review

> Source/WebCore/ChangeLog:3
> +        <input> size attribute does not return default when attribute outofrange

This is the bug title, but it doesn't match what you will fix.
It seems the original issue was already fixed, and you'll fix Comment #2, right?  If so, we should change the bug title.

> Source/WebCore/html/HTMLInputElement.h:210
> -    void setSize(unsigned);
> +    void setSize(unsigned, ExceptionCode&);

Unfortunately Objective-C binding needs setSize(unsigned).  We should have both.

> LayoutTests/ChangeLog:11
> +        * fast/forms/input-size-expected.txt: Added.
> +        * fast/forms/input-size.html: Added.

We already have fast/dom/HTMLInputElement/input-size-attribute.html.  Would you add your test case to it please?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.