[Webkit-unassigned] [Bug 91844] [WK2][GTK][EFL] Share WebKit2-GTK plugin process implementation with EFL port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91844





--- Comment #67 from Mariusz Grzegorczyk <mariusz.g at samsung.com>  2012-10-03 03:30:37 PST ---
(In reply to comment #66)
> (In reply to comment #64)
> > (From update of attachment 166244 [details] [details])
> > Clearing flags on attachment: 166244
> > 
> > Committed r129972: <http://trac.webkit.org/changeset/129972>
> 
> Hi,
> 
> This change has broken the EFL build if one passes --no-netscape-plugin-api to build-webkit. Can you take a look at this, Mariusz?

I've made initial investigation and it seems that when PLUGIN_PROCESS is on and NETSCAPE_PLUGIN_API is off it causes a lot of buildbreaks. On some ports like Gtk both macros are on and there is no way to disable them from build-webkit script. 
In webkit1 there was only netscape plugin api macro which means all functionality is on/off. But in webkit2 it is more confusing, e.g. createPlugin function in WebPage.cpp:

#if ENABLE(PLUGIN_PROCESS)
    return PluginProxy::create(pluginPath);
#elif ENABLE(NETSCAPE_PLUGIN_API)
    NetscapePlugin::setSetExceptionFunction(NPRuntimeObjectMap::setGlobalException);
    return NetscapePlugin::create(NetscapePluginModule::getOrCreate(pluginPath));
#else
    return 0;
#endif

Later when plugin process is initialized in PluginControllerProxy.cpp:
m_plugin = NetscapePlugin::create(PluginProcess::shared().netscapePluginModule());
NetscapePlugin::create is invoked which is in macro NETSCAPE_PLUGIN_API

I'm wondering if plugin process should be created at all when NETSCAPE_PLUGIN_API is off. also getting plugin path in WebPage::createPlugin seems to be useless when plugins are off.
I think it will be good to make new bug on bugzilla for this combination of macros.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.