[Webkit-unassigned] [Bug 96774] [GTK] Don't use the C API internally in WebKitFileChooserRequest
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Oct 3 01:37:53 PDT 2012
https://bugs.webkit.org/show_bug.cgi?id=96774
--- Comment #3 from Mario Sanchez Prada <msanchez at igalia.com> 2012-10-03 01:38:17 PST ---
(From update of attachment 164134)
View in context: https://bugs.webkit.org/attachment.cgi?id=164134&action=review
Looks good to me. I just have a really minor comment
> Source/WebKit2/UIProcess/API/gtk/WebKitFileChooserRequest.cpp:255
> + if (!mimeTypes->size())
Why not using the numOfMimeTypes variable here? I know it's not crucial stuff, but you will need to call mimeTypes->size() again below, so it might be handy
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list