[Webkit-unassigned] [Bug 96769] [GTK] Don't use the C API internally in WebKitBackForwardList

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=96769





--- Comment #4 from Mario Sanchez Prada <msanchez at igalia.com>  2012-10-03 01:31:27 PST ---
(From update of attachment 166481)
View in context: https://bugs.webkit.org/attachment.cgi?id=166481&action=review

This patch is pretty straightforward and I have not much to comment here. LGTM

> Source/WebKit2/UIProcess/API/gtk/WebKitBackForwardList.cpp:58
> +    WebBackForwardList* webList;

I would probably name it backForwardList instead of webList. But I'm not genius choosing names either, so take it as a subjective opinion.

> Source/WebKit2/UIProcess/API/gtk/WebKitBackForwardList.cpp:140
> +WebKitBackForwardList* webkitBackForwardListCreate(WebBackForwardList* webList)

Ditto

> Source/WebKit2/UIProcess/API/gtk/WebKitBackForwardListItem.cpp:32
> +    RefPtr<WebBackForwardListItem> webListItem;

And here too. Or maybe just listItem here, not to make it too long

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.