[Webkit-unassigned] [Bug 98188] ReplaceSelectionCommand should merge text nodes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=98188





--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org>  2012-10-02 16:18:12 PST ---
(From update of attachment 166770)
View in context: https://bugs.webkit.org/attachment.cgi?id=166770&action=review

> Source/WebCore/editing/ReplaceSelectionCommand.cpp:1185
> +    bool notStart = !isStartOfParagraph(startOfInsertedContent);
> +    VisiblePosition p = startOfInsertedContent.previous();
> +    UChar32 c = p.characterAfter();
> +    if (c == noBreakSpace)
> +        c = ' ';
> +    bool needsLeadingSpace = notStart && !isCharacterSmartReplaceExempt(c, true);

isCharacterSmartReplaceExempt returns false on nbsp :( But we shouldn't be adding a space between words when there's already a non-breaking space.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.