[Webkit-unassigned] [Bug 97895] [GTK] Add API to get the web view that initiated a custom URI request to WebKit2 GTK+

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=97895


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #166223|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #4 from Martin Robinson <mrobinson at webkit.org>  2012-10-02 13:34:22 PST ---
(From update of attachment 166223)
View in context: https://bugs.webkit.org/attachment.cgi?id=166223&action=review

Okay. This looks good to me. I wish there was a cleaner way to get the frame from the networking request, but

> Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:700
> +    uint64_t* initiatingPageIDPtr = g_slice_new(uint64_t);

You should use FastAlloc instead of the GLib allocator here.

>> Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:703
>> +                           reinterpret_cast<GDestroyNotify>(initiatingPageIDPtrFree));
> 
> Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]

Please fix this before landing.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.