[Webkit-unassigned] [Bug 96717] Turn forbidEventDispatch and allowEventDispatch into a RAII object

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=96717





--- Comment #20 from Ojan Vafai <ojan at chromium.org>  2012-10-02 11:33:17 PST ---
(In reply to comment #19)
> (In reply to comment #18)
> > I think this may have caused a performance regression.
> > 
> > http://build.chromium.org/f/chromium/perf/mac-release-10.6-webkit-latest/dromaeo_domcoreattr/report.html?history=150&rev=-1&graph=dom_attr_element_expando___value
> > http://build.chromium.org/f/chromium/perf/mac-release-10.6-webkit-latest/dromaeo_jslibtraversejquery/report.html?history=150&rev=-1&graph=jslib_traverse_jquery_jQuery___parents_x10
> > http://trac.webkit.org/log/?verbose=on&rev=130076&stop_rev=130069
> 
> 
> I think the code added here
> http://trac.webkit.org/changeset/130093/trunk/Source/WebCore/dom/ContainerNode.h
> 
> if (!isMainThread()) 
>     return; 
> 
> needs to be in #ifndef NDEBUG

Actually, I think we're fine. It looks like it was rolling in a new version of V8 that caused the regression.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.