[Webkit-unassigned] [Bug 98174] Unix plugin process: xErrorString does not need to be defined in release builds

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=98174





--- Comment #4 from Adrian Perez <aperez at igalia.com>  2012-10-02 10:27:15 PST ---
(In reply to comment #3)
> (From update of attachment 166707 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=166707&action=review
> 
> > Source/WebKit2/PluginProcess/unix/PluginProcessMainUnix.cpp:54
> > +#ifndef LOG_DISABLED
> >  static const char* xErrorString = "The program '%s' received an X Window System error.\n"
> >      "This probably reflects a bug in a browser plugin.\n"
> >      "The error was '%s'.\n"
> >      "  (Details: serial %ld error_code %d request_code %d minor_code %d)\n";
> > +#endif /* !LOG_DISABLED */
> 
> Could also make this a bit more const. Either const char[] or const char* const.

Sure, thanks. Will make it “const char[]” and re-upload the patch. Thanks!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.