[Webkit-unassigned] [Bug 98064] ScrollView::setScrollPosition is overridden by FrameView, but is not virtual

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=98064





--- Comment #4 from Tim Horton <timothy_horton at apple.com>  2012-10-02 09:46:17 PST ---
(In reply to comment #3)
> (From update of attachment 166536 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=166536&action=review
> 
> > Source/WebCore/platform/ScrollView.h:187
> > +    virtual void setScrollPosition(const IntPoint&);
> 
> I recommend using the OVERRIDE macro in cases like this.

Hi, Darin!

I did, on FrameView (the overriding subclass). I don't think it belongs on ScrollView since ScrollView is originating setScrollPosition, right?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.