[Webkit-unassigned] [Bug 98063] [GTK] [WK2] Add favicon support to the MiniBrowser

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=98063





--- Comment #7 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-10-02 08:17:27 PST ---
(In reply to comment #6)
> (From update of attachment 166669 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=166669&action=review
> 
> Thanks for taking care of this, Berto. The patch looks good to me in general, I've just have a couple of really minor comments
> 
> > Tools/ChangeLog:18
> > +        (browserWindowConstructed):
> 
> You should provide a brief description for each of these functions
> 
> > Tools/MiniBrowser/gtk/BrowserWindow.c:397
> > +        window->favicon = NULL;
> 
> You could use g_clear_object() here

Make sure we depend on a recent enough glib to use g_clear_object

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.