[Webkit-unassigned] [Bug 98063] [GTK] [WK2] Add favicon support to the MiniBrowser

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=98063





--- Comment #6 from Mario Sanchez Prada <msanchez at igalia.com>  2012-10-02 06:44:17 PST ---
(From update of attachment 166669)
View in context: https://bugs.webkit.org/attachment.cgi?id=166669&action=review

Thanks for taking care of this, Berto. The patch looks good to me in general, I've just have a couple of really minor comments

> Tools/ChangeLog:18
> +        (browserWindowConstructed):

You should provide a brief description for each of these functions

> Tools/MiniBrowser/gtk/BrowserWindow.c:397
> +        window->favicon = NULL;

You could use g_clear_object() here

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.