[Webkit-unassigned] [Bug 98063] [GTK] [WK2] Add favicon support to the MiniBrowser

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=98063





--- Comment #2 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-10-02 01:19:38 PST ---
(From update of attachment 166631)
View in context: https://bugs.webkit.org/attachment.cgi?id=166631&action=review

I guess you should also unref the favicon pixbuf in finalize().

> Tools/MiniBrowser/gtk/BrowserWindow.c:375
> +    cairo_surface_t *surface;
> +
> +    surface = webkit_web_view_get_favicon(window->webView);

Use a single line here:

cairo_surface_t *surface = webkit_web_view_get_favicon(window->webView);

> Tools/MiniBrowser/gtk/BrowserWindow.c:445
> +    g_signal_connect(window->uriEntry, "notify::text", G_CALLBACK(uriEntryTextChanged), (gpointer)window);

Don't use the gpointer cast, it's not needed, I know there are several there already, but that's old code copied from GtkLauncher, I think.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.