[Webkit-unassigned] [Bug 93170] Inline continuations create :after generated content on style recalcs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=93170





--- Comment #14 from Takashi Sakamoto <tasak at google.com>  2012-10-02 01:09:15 PST ---
I'm sorry. I said wrong things.
I looked at my old patch for bug 93707 again and found that we need to enable updating :after content during curr->setStyle.
To show why we need, I added one more layout test to this patch. The test updates className to apply / not to apply :after to inline elements. If we disable updating :after content in curr->setStyle, no generated renderer for :after content is created.

Best regards,
Takashi Sakamoto

(In reply to comment #11)
> (From update of attachment 166603 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=166603&action=review
> 
> One more round.
> 
> > Source/WebCore/rendering/RenderInline.cpp:169
> > +    bool updateEnabled = RenderObjectChildList::enableUpdateBeforeAfterContent(false);
> 
> you can use TemporaryChange to scope this easily. see comment below.
> 
> > Source/WebCore/rendering/RenderObjectChildList.cpp:443
> > +    if (!m_enableUpdateBeforeAfterContent)
> 
> Why so late return ? Why not after the line " if (owner->style()->styleType() == BEFORE || owner->style()->styleType() == AFTER)"
> 
> > Source/WebCore/rendering/RenderObjectChildList.h:59
> > +    static bool enableUpdateBeforeAfterContent(bool enable)
> 
> You don't need this. Just use TemporaryChange.h, see http://code.google.com/codesearch#OAMlx_jo-ck/src/third_party/WebKit/Tools/TestWebKitAPI/Tests/WTF/TemporaryChange.cpp&exact_package=chromium&q=%22TemporaryChange%3Cbool%22&type=cs&l=36. Make m_enableUpdateBeforeAfterContent a global static that could be manipulated by  RenderInline::styleDidChange.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.