[Webkit-unassigned] [Bug 93170] Inline continuations create :after generated content on style recalcs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=93170


Abhishek Arya <inferno at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #166603|review?                     |review-
               Flag|                            |




--- Comment #11 from Abhishek Arya <inferno at chromium.org>  2012-10-01 22:05:46 PST ---
(From update of attachment 166603)
View in context: https://bugs.webkit.org/attachment.cgi?id=166603&action=review

One more round.

> Source/WebCore/rendering/RenderInline.cpp:169
> +    bool updateEnabled = RenderObjectChildList::enableUpdateBeforeAfterContent(false);

you can use TemporaryChange to scope this easily. see comment below.

> Source/WebCore/rendering/RenderObjectChildList.cpp:443
> +    if (!m_enableUpdateBeforeAfterContent)

Why so late return ? Why not after the line " if (owner->style()->styleType() == BEFORE || owner->style()->styleType() == AFTER)"

> Source/WebCore/rendering/RenderObjectChildList.h:59
> +    static bool enableUpdateBeforeAfterContent(bool enable)

You don't need this. Just use TemporaryChange.h, see http://code.google.com/codesearch#OAMlx_jo-ck/src/third_party/WebKit/Tools/TestWebKitAPI/Tests/WTF/TemporaryChange.cpp&exact_package=chromium&q=%22TemporaryChange%3Cbool%22&type=cs&l=36. Make m_enableUpdateBeforeAfterContent a global static that could be manipulated by  RenderInline::styleDidChange.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.