[Webkit-unassigned] [Bug 80794] :first-line pseudo selector ignoring words created from :before

Mon Oct 1 20:45:10 PDT 2012

https://bugs.webkit.org/show_bug.cgi?id=80794

Daniel Bates <dbates at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #163788|review?                     |review-
               Flag|                            |

--- Comment #14 from Daniel Bates <dbates at webkit.org>  2012-10-01 20:45:32 PST ---
(From update of attachment 163788)
View in context: https://bugs.webkit.org/attachment.cgi?id=163788&action=review

Please remove the tab characters from files LayoutTests/fast/css/first-line-style-for-before-after-{content, content-expected}.html. In particular, lines 13, 19, 20, and 21 contain tab characters in file first-line-style-for-before-after-content.html and lines 16, 22, 23, 24 contain tab characters in file first-line-style-for-before-after-content-expected.html.

> LayoutTests/fast/css/first-line-style-for-before-after-content-expected.html:23
> +</html>

Nit: Missing a newline character at the end of this file.

> LayoutTests/fast/css/first-line-style-for-before-after-content.html:1
> +<!DOCTYPE html>

The name of this test is disingenuous as it only tests the combination of :first-line, :first-letter, and :before pseudo-elements. That is, it doesn't test the combination :first-line, :first-letter, and :after pseudo elements. Even though we have a single code path for handling before and after content (via the check for Render::isBeforeOrAfterContent()), I suggest that we either rename this test and its descriptive to make it explicit that it's only testing :first-line, :first-letter, and :before pseudo elements OR, even better, add a test that makes use of :first-line, :first-letter, and :after pseudo elements.

> LayoutTests/fast/css/first-line-style-for-before-after-content.html:26
> +</html>

Nit: Missing a newline character at the end of this file.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.