[Webkit-unassigned] [Bug 96286] Another SIGILL in JavaScriptCore on a Geode processor

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=96286





--- Comment #11 from Darin Adler <darin at apple.com>  2012-10-01 14:32:55 PST ---
(From update of attachment 166502)
View in context: https://bugs.webkit.org/attachment.cgi?id=166502&action=review

> Source/WTF/wtf/Platform.h:904
> +/* On the GTK+ port we take an extra precaution for LLINT support:
> + * We disable it on x86 builds if the build target doesn't support SSE2
> + * instructions (LLINT requires SSE2 on this platform). */

Other comments in this file are using spaces to indent subsequent lines of comments, not * with space.

> Source/WTF/wtf/Platform.h:906
> +#if !defined(ENABLE_LLINT) && PLATFORM(GTK) && CPU(X86) && COMPILER(GCC) \
> +    && !defined(__SSE2__)

WebKit coding style would put this all on a single line. I don’t think this line breaking should be done here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.